Fire GSplatSorter 'updated' event immediately for renderNextFrame support#8500
Merged
mvaligursky merged 1 commit intomainfrom Mar 4, 2026
Merged
Fire GSplatSorter 'updated' event immediately for renderNextFrame support#8500mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
…port Move the 'updated' event from applyPendingSorted() to the worker message callback so listeners are notified as soon as sort results arrive. This ensures renderNextFrame is triggered promptly when autoRender is disabled. The splat count is now returned from applyPendingSorted() instead of being passed via the event, and GSplatInstance.update() applies it directly. Made-with: Cursor
mvaligursky
added a commit
that referenced
this pull request
Mar 4, 2026
…port (#8500) Move the 'updated' event from applyPendingSorted() to the worker message callback so listeners are notified as soon as sort results arrive. This ensures renderNextFrame is triggered promptly when autoRender is disabled. The splat count is now returned from applyPendingSorted() instead of being passed via the event, and GSplatInstance.update() applies it directly. Made-with: Cursor Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
'updated'event inGSplatSorterfromapplyPendingSorted()to the worker message callback, so listeners are notified as soon as sort results arrive. This ensuresrenderNextFrameis triggered promptly whenautoRenderis disabled, avoiding a one-frame delay.applyPendingSorted()to return the splat count instead of firing an event with it.GSplatInstance.update()uses the return value directly to setinstancingCountand thenumSplatsmaterial parameter.