Skip to content

Tests - Environment Targets#69

Open
AdrianRomanski wants to merge 28 commits intopush-based:mainfrom
AdrianRomanski:tests-environment-targets
Open

Tests - Environment Targets#69
AdrianRomanski wants to merge 28 commits intopush-based:mainfrom
AdrianRomanski:tests-environment-targets

Conversation

@AdrianRomanski
Copy link
Member

@AdrianRomanski AdrianRomanski commented Dec 12, 2024

No description provided.

AdrianRomanski and others added 21 commits December 12, 2024 19:29
@AdrianRomanski
tests: add tests structure
0446e1d
@AdrianRomanski
Merge branch 'main' into tests-environment-targets
68335da
@AdrianRomanski
tests: add is env project basic tests
12e8a70
@AdrianRomanski
Merge remote-tracking branch 'origin/tests-environment-targets' into …
7cabb77 
…tests-environment-targets
@AdrianRomanski
tests: change names, memory optimization, code cleanup
f375096
@AdrianRomanski
tests: verdaccio targets failing test
97609e6
@AdrianRomanski
tests: add object generation, join calls, uniquePort calls
c020b13
@AdrianRomanski
tests: memory and variables optimization
e9c17d2
@AdrianRomanski
tests: clean up, format, mockRestore
64a47f1
@AdrianRomanski
tests: add getEnvTargets structure testing, and nested objects struct…
dd87b63 
…ure&data
@AdrianRomanski
tests: variables, magic strings optimization
ec7e9ee
@AdrianRomanski
tests: improve naming
4a0b943
@AdrianRomanski
tests: add join spy calls and arguments check
e32e786
@AdrianRomanski
tests: add update target names
87b7f74
@AdrianRomanski
tests: updateEnvTargetNames variables optimization
a8d52dc
@AdrianRomanski
tests: format write
767f1e4
@AdrianRomanski
tests: refactor local describe lock variables into global ones
a9ea4bd
@AdrianRomanski
tests: imports organization, code cleanup
bcd70b8
@AdrianRomanski
tests: code cleanup
bafdc91
@AdrianRomanski
self-review: code cleanup, names changes, variables optimization, spl…
5e11787 
…it verdaccioTargets into 3 tests
@AdrianRomanski
docs: add isEnvProject, verdaccioTargets
062a5c0
@AdrianRomanski AdrianRomanski marked this pull request as ready for review January 8, 2025 07:46
@AdrianRomanski
Copy link
Member Author

AdrianRomanski commented Jan 8, 2025

I have paid attention to everything mentioned in the cache PR:

Avoid unnecessary describe block nesting.
Use spies and mocks consistently.
Improve test naming for better clarity.
Make mocks as minimal as possible and keep them in the same file.
Perform a self-review.
As an extra, I’ve also written some missing documentation this time. :)

@AdrianRomanski AdrianRomanski mentioned this pull request Jan 10, 2025
Open
BioPhoton
BioPhoton requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR and increasing test code coverage. I left some comments to improve the naming and structure.

@AdrianRomanski
Copy link
Member Author

AdrianRomanski commented Jan 18, 2025 •
edited
Loading

Things done after review

  1. Inline every const that were used once
  2. Group tests by happy/unhappy path
  3. Better test phrasing (mostly generating part)
  4. Self review (catch one grouping that was left)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhoton BioPhoton BioPhoton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdrianRomanski @BioPhoton