fix: use pathlib.Path.as_uri() for base href in render_to_img#14
Merged
drmingdrmer merged 2 commits intomasterfrom Feb 22, 2026
Merged
fix: use pathlib.Path.as_uri() for base href in render_to_img#14drmingdrmer merged 2 commits intomasterfrom
drmingdrmer merged 2 commits intomasterfrom
Conversation
Replace raw `"file://"` string concatenation with `pathlib.Path.as_uri()` for the `<base href>` tag, fixing cross-platform issues (backslashes on Windows, missing third slash, unescaped spaces). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"file://"string concatenation withpathlib.Path.as_uri()for the<base href>tag inrender_to_img()page.goto()Test plan
make test— all 14 tests passrender_to_imgwithasset_baseproduces correct file URIs