Skip to content

fix: use pathlib.Path.as_uri() for base href in render_to_img #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drmingdrmer merged 2 commits into from
Feb 22, 2026
+2 −2
Merged

fix: use pathlib.Path.as_uri() for base href in render_to_img #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
645bac5
fix: use `pathlib.Path.as_uri()` for `<base href>` in `render_to_img()`
drmingdrmer Feb 22, 2026
cfb1e84
fix: remove unused html_escape import
drmingdrmer Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions down2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import urllib.error
import urllib.parse
import urllib.request
from html import escape as html_escape

from PIL import Image, ImageChops
from playwright.sync_api import Browser, sync_playwright
Expand Down Expand Up @@ -371,7 +370,8 @@ def render_to_img(
input = r'<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>' + input

if asset_base is not None:
input = '<base href="file://{}/">'.format(html_escape(asset_base)) + input
base_uri = pathlib.Path(asset_base).as_uri()
input = '<base href="{}/">'.format(base_uri) + input

m = mimetypes.get(mime) or mime

Expand Down