Implement shared XTensorVariables#1882
Merged
ricardoV94 merged 1 commit intopymc-devs:mainfrom Feb 10, 2026
Merged
Conversation
ricardoV94
force-pushed
the
xtensor_shared_variables
branch
from
bc9b5ca to
30c550c
Compare
jessegrabowski
approved these changes
Feb 10, 2026
Member
jessegrabowski
left a comment
jessegrabowski
left a comment
There was a problem hiding this comment.
small nitpicks, apply if desired otherwise good to go
| if not all(isinstance(dim, str) for dim in xarray_dims): | ||
| raise NotImplementedError( | ||
| "DataArray can only be converted to xtensor_constant if all dims are of string type" | ||
| "DataArray can only be converted to xtensor if all dims are of string type" |
Member
There was a problem hiding this comment.
We don't auto-generate dim__0 dim__1 etc like arviz?
Member
Author
There was a problem hiding this comment.
no, I opted to be more picky so you don't accidentally end up broadcasting things / misaligning variables
ricardoV94
force-pushed
the
xtensor_shared_variables
branch
from
30c550c to
9125e8e
Compare
ricardoV94
force-pushed
the
xtensor_shared_variables
branch
from
9125e8e to
6586968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would love for us to move away from shared variables, but that's not on the table in the foreseeable future.
Therefore we should allow them to also be shared, so that we can use xtensor more seamless in the rest of the ecosystem.