Initial Implementation for supporting EXTRA_ARGS for command line options for tests#53
Conversation
Signed-off-by: Ameya Vikram Singh <ameya.v.singh@gmail.com>
Signed-off-by: Ameya Vikram Singh <ameya.v.singh@gmail.com>
buddly27
left a comment
There was a problem hiding this comment.
Thanks for your contribution, this is great!
As discussed in my review notes, I feel like this PR should focus on handling extra arguments for running the tests and leave the handling of extra arguments for test discovery to a separate PR, as it would likely require additional checks to ensure they don't interfere with the parsing logic.
Let me know what you think!
Signed-off-by: Ameya Vikram Singh <ameya.v.singh@gmail.com>
I have updated the implementation to reflect the changes. |
buddly27
left a comment
There was a problem hiding this comment.
It looks great, thank you! I really appreciate you adding unit tests as well.
This PR adds initial support to specify custom
EXTRA_ARGStopytest_discover_testsfunction inFindPytest.cmake.Add support for #19 .