Closed
Conversation
This test gives us a lot of confidence that the import scanning still works.
c7bee51 to
f0d4871
Compare
CodSpeed Instrumentation Performance ReportMerging #222 will degrade performances by 77.57%Comparing Summary
Benchmarks breakdown
|
Closed
Merged
Collaborator
Author
|
Closing this one since we're working on it in other PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sketch of bulk import scanning via rust.
Ideas to make this nicer:
ImportScannerpython interface obsolete. We should likely instead introduce aBulkImportScannerinterface, which processes all modules at once.This seems to make import scanning a little bit faster on my machine, but the change doesn't seem to be really big.