Skip to content

Fix numeric comparison in evaluate bug#426

Merged
laander merged 1 commit intomainfrom
Fix-numeric-comparison-in-evaluate-bug
Jun 18, 2025
Merged

Fix numeric comparison in evaluate bug#426
laander merged 1 commit intomainfrom
Fix-numeric-comparison-in-evaluate-bug

Conversation

@laander
Copy link
Contributor

@laander laander commented Jun 18, 2025

In local evaluation for the Node SDK:

Fix numeric comparison for GT/LT operators where casting strings to numbers wasn't being done correctly happen.
That could result in situations where "2" > "10" == true

Added test case

Note: replaces #424 which was created from another remote (forked repo) which meant that GH actions build and test wouldn't run

@laander laander added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 13a0aa5 Jun 18, 2025
6 checks passed
@laander laander deleted the Fix-numeric-comparison-in-evaluate-bug branch June 18, 2025 13:05
github-merge-queue bot pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants