Skip to content

Fix numeric comparison in evaluate bug #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laander merged 1 commit into from
Jun 18, 2025
Merged

Fix numeric comparison in evaluate bug #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/flag-evaluation/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,15 @@ export function evaluate(
);
return false;
}
return fieldValue > value;
return Number(fieldValue) > Number(value);
case "LT":
if (isNaN(Number(fieldValue)) || isNaN(Number(value))) {
console.error(
`LT operator requires numeric values: ${fieldValue}, ${value}`,
);
return false;
}
return fieldValue < value;
return Number(fieldValue) < Number(value);
case "AFTER":
case "BEFORE": {
// more/less than `value` days ago
Expand Down
4 changes: 4 additions & 0 deletions packages/flag-evaluation/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,10 +381,14 @@ describe("operator evaluation", () => {
["value", "GT", "value", false],
["value", "GT", "0", false],
["1", "GT", "0", true],
["2", "GT", "10", false],
["10", "GT", "2", true],

["value", "LT", "value", false],
["value", "LT", "0", false],
["0", "LT", "1", true],
["2", "LT", "10", true],
["10", "LT", "2", false],

["start VALUE end", "CONTAINS", "value", true],
["alue", "CONTAINS", "value", false],
Expand Down