Skip to content

fix: version check can cause failures #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roncohen merged 2 commits into from
Sep 22, 2025
Merged

fix: version check can cause failures #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4eeed
fix: version check can cause failures
roncohen Sep 17, 2025
a1e27b0
clean up
roncohen Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions packages/cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ type Options = {

async function main() {
// Start a version check in the background
const cliVersionCheckPromise = checkLatestVersion();
// unhandled promise rejection can happen even without the `await`
// so we need a `catch` here.
const cliVersionCheckPromise = checkLatestVersion().catch(() => ({
latestVersion: "unknown",
currentVersion: "unknown",
isNewerAvailable: false,
}));

// Must load tokens and config before anything else
await authStore.initialize();
Expand Down Expand Up @@ -91,19 +97,15 @@ async function main() {
}
}

try {
const { latestVersion, currentVersion, isNewerAvailable } =
await cliVersionCheckPromise;
const { latestVersion, currentVersion, isNewerAvailable } =
await cliVersionCheckPromise;

if (isNewerAvailable) {
console.info(
`A new version of the CLI is available: ${chalk.yellow(
currentVersion,
)} -> ${chalk.green(latestVersion)}. Update to ensure you have the latest features and bug fixes.`,
);
}
} catch {
// Ignore errors
if (isNewerAvailable) {
console.info(
`A new version of the CLI is available: ${chalk.yellow(
currentVersion,
)} -> ${chalk.green(latestVersion)}. Update to ensure you have the latest features and bug fixes.`,
);
}

if (debug) {
Expand Down
1 change: 0 additions & 1 deletion packages/cli/utils/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export async function checkLatest() {

const latestVersion = await getLatestVersionFromNpm(packageName);
const isNewerAvailable = gt(latestVersion, currentVersion);

return {
currentVersion,
latestVersion,
Expand Down