Improve pkgdown articles; add a new article on filling layouts #498

cpsievert · 2023-03-07T16:51:19Z

No description provided.

I think it's a little easier to understand, especially if you were to drop into an example halfway through the article

only relevant for local previews

top-level in the article should be <h2>

…m and fillable-container behavior

R/card.R

* Move `map_quakes` to setup code * Shared -> Local -> Fillable * Add resizable iframe option

Easier to globally gitignore, harder to accidentally overwrite an example

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

… testing/coercing fill behavior; keep working on vignettes

…der tag (just like a string is) (#513) * Close #512. A numeric value for value_box()'s title/value is now wrapped in a header tag (just like a string is) * `devtools::document()` (GitHub Actions) * Update R/value-box.R Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com> * Update value-box.R * `devtools::document()` (GitHub Actions) * Resave data (GitHub Action) --------- Co-authored-by: cpsievert <cpsievert@users.noreply.github.com> Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

…ontents more specific (#520) * Close #519: make the CSS selector for adding margin between the navbar and it's contents more specific * Resave distributed files (GitHub Action) * Resave data (GitHub Action) --------- Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>

* Prevent collapsed sidebar from having a non-zero height * Hide sidebar content while transitioning, too For symmetry with the collapsing transition, but also reduces layout shifts as the sidebar expands * Resave distributed files (GitHub Action) --------- Co-authored-by: Carson <cpsievert1@gmail.com> Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com>

Co-authored-by: Carson Sievert <cpsievert1@gmail.com> Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>

Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com>

cpsievert · 2023-04-05T22:55:06Z

Closing this since I decided to break up this PR into several, more digestable PRs

Change card_body() to be a fillable container; deprecate card_body_fill(); add/change other fill/fillable uses for consistency-sake #534, for more immediate code changes we know we want to take on
Add is_fill()/as_fill() helpers #536, for the more speculative is_fill()/as_fill()
Update pkgdown articles to better describe/reflect new fillable/fill concepts #537, for the pkgdown improvements

gadenbuie and others added 14 commits March 6, 2023 14:04

Rename filter controls with filter_ prefix

3d8548d

I think it's a little easier to understand, especially if you were to drop into an example halfway through the article

remove trailing invisible space

21efc6c

Ignore rendered vignette html files

9491964

Consolidate iframe rendering in a knitr option hook

143e9bd

Use html_document with BS5 for local editing

105cb03

only relevant for local previews

Fix base heading level

1340c7d

top-level in the article should be <h2>

Add global/local sidebar grid

0c00864

Reword footnote

586c5d2

Merge 'origin/main' into branch 'garrick/sidebar-article-edits'

7412ee5

rewrite showcase

bb7b6f4

Suppress headroom on page_navbar() example

47643df

Add callout styles and use callout for global sidebar warning

4ce38ae

wording tweak

fd09115

wip consistently use and expose fill/fillable as controls to fill-ite…

ea0ce14

…m and fillable-container behavior

cpsievert commented Mar 7, 2023

View reviewed changes

R/card.R Outdated Show resolved Hide resolved

devtools::document() (GitHub Actions)

98497f3

cpsievert mentioned this pull request Mar 7, 2023

Work items for next release #493

Closed

5 tasks

gadenbuie and others added 13 commits March 7, 2023 13:42

Give h2 a little more breathing room

7ea8707

diamonds is from {ggplot2}

e45a57b

edit setup code introduction

318bc13

global -> shared and shared first

5d023f7

Move "dynamic sidebars" to Shiny section

2c3701c

Simplify sidebar state observer code

a89c185

Rewrite navbar page section

f5f3d8a

* Move `map_quakes` to setup code * Shared -> Local -> Fillable * Add resizable iframe option

Deprecate page_fill() in favor of page_fillable()

476eecf

Change default card_body() behavior for the better

806264e

devtools::document() (GitHub Actions)

f0acc39

Update website deps (GitHub Action)

c30138a

fixup shared- and local-sidebar IDs

292edb5

Render iframe examples into examples/sidebars directory

51501d1

Easier to globally gitignore, harder to accidentally overwrite an example

cpsievert and others added 11 commits March 10, 2023 14:54

Update vignettes/cards.Rmd

eef4074

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

04597f6

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

14f0da5

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

00360b1

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

0b8134c

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/sidebars.Rmd

8698297

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

ee4ee29

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

eb21a63

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

826e35a

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Update vignettes/cards.Rmd

7636084

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

devtools::document() (GitHub Actions)

1bb52a3

cpsievert self-assigned this Mar 14, 2023

cpsievert and others added 13 commits March 15, 2023 15:18

page_navbar(fillable) shouldn't include padding/gap

c1393e1

Prevent collapsed sidebar from having a non-zero height

8a848a9

Resave distributed files (GitHub Action)

8ded96b

Resave data (GitHub Action)

f9e80e2

Merge branch 'main' into fillable-api

2e0732a

Resave data (GitHub Action)

73b2e82

wip another pass at sidebar article and other articles

d064d19

wip have card_body() default to fillable container; add utilities for…

9a7c46d

… testing/coercing fill behavior; keep working on vignettes

Adjust sidebar function signature and require sidebar argument (#525)

0465eab

Co-authored-by: Carson Sievert <cpsievert1@gmail.com> Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>

Apply sidebar transition fix on non-mobile widths only (#527)

190b593

Co-authored-by: gadenbuie <gadenbuie@users.noreply.github.com>

cpsievert mentioned this pull request Apr 5, 2023

Change card_body() to be a fillable container; deprecate card_body_fill(); add/change other fill/fillable uses for consistency-sake #534

Merged

cpsievert changed the title ~~Synchronize/improve fill/fillable controls; add/improve pkgdown articles~~ Improve pkgdown articles; add a new article on filling layouts Apr 5, 2023

cpsievert closed this Apr 5, 2023

cpsievert deleted the fillable-api branch July 14, 2023 22:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve pkgdown articles; add a new article on filling layouts #498

Improve pkgdown articles; add a new article on filling layouts #498

Uh oh!

cpsievert commented Mar 7, 2023 •

edited

Loading

Uh oh!

Uh oh!

cpsievert commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Improve pkgdown articles; add a new article on filling layouts #498

Improve pkgdown articles; add a new article on filling layouts #498

Uh oh!

Conversation

cpsievert commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cpsievert commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cpsievert commented Mar 7, 2023 •

edited

Loading