Change card_body() to be a fillable container; deprecate card_body_fill(); add/change other fill/fillable uses for consistency-sake #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Apr 5, 2023
cpsievert
commented
Apr 5, 2023
cpsievert
force-pushed
the
fill-api-changes
branch
from
a11d7c0 to
d1dee45
Compare
…ll(); add/change other fill/fillable uses for consistency-sake
cpsievert
force-pushed
the
fill-api-changes
branch
from
d1dee45 to
5b549c3
Compare
cpsievert
commented
Apr 5, 2023
cpsievert
commented
Apr 5, 2023
This was referenced Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by work done in #498 (pulling all code changes out of there into more digestable PRs).
Closes #511