Skip to content

Add const Default impls for HashSet and HashMap with custom Hasher #151190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
estebank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add const Default impls for HashSet and HashMap with custom Hasher #151190

estebank wants to merge 1 commit into from
+24 −11

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Jan 16, 2026 •
edited by rustbot
Loading

Follow up to #134628. Tracking issue #143894.

r? @fmease

cc @fee1-dead @oli-obk

This doesn't allow for const H: HashSet<()> = Default::default();, but would allow for it to work with a custom hasher, which would enable the Fx* family to work.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 16, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

fmease is not on the review rotation at the moment.
They may take a while to respond.

@fmease fmease changed the title Add const Default impls for HashSet and HashMap with custom Hahser Add const Default impls for HashSet and HashMap with custom Hasher Jan 16, 2026
oli-obk
oli-obk reviewed Jan 16, 2026
View reviewed changes
@estebank estebank mentioned this pull request Jan 16, 2026
Open
@estebank estebank force-pushed the const-default-hashmap branch from 3173ea4 to 5f58acb Compare January 16, 2026 16:32
@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 17, 2026

📌 Commit 5f58acb has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@fmease fmease

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estebank @rustbot @oli-obk @fmease