Skip to content

Conversation

@StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Jan 22, 2026

Merges into #5491

Changes proposed in this pull request

  • Do not raise InternalValidationErrors if a sample should not be accessioned
  • Replace scope for_sample_accessioning with Railsy model methods
  • Refactor validatation of studies for accessioning
  • Removes error messages and does not accession these samples, but records a reason as a rails log instead
    • Sample is linked to a study that does not require accessioning.
    • Sample is not linked to any studies but must be linked to exactly one study.
    • Removes a lot of email spam...
  • Update tests

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the title Y25-705 - Separate accession eligibility from validity Y25-286 - Separate accession eligibility from validity Jan 22, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (8851d11) to head (1b63341).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5486      +/-   ##
===========================================
- Coverage    87.39%   87.28%   -0.12%     
===========================================
  Files         1457     1457              
  Lines        32705    32703       -2     
  Branches      3423     3422       -1     
===========================================
- Hits         28584    28545      -39     
- Misses        4106     4143      +37     
  Partials        15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme changed the base branch from develop to Y25-286-refactor-data-release-timings January 23, 2026 11:48
@StephenHulme StephenHulme self-assigned this Jan 23, 2026
@StephenHulme StephenHulme added the Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. label Jan 23, 2026
@StephenHulme StephenHulme force-pushed the y25-705-calm-agressive-validation branch from 9d5b9a4 to 47291b5 Compare January 26, 2026 09:37
@StephenHulme
Copy link
Contributor Author

Moved later developments into #5499

Copy link
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions, looks good.

Base automatically changed from Y25-286-refactor-data-release-timings to develop January 27, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants