-
Notifications
You must be signed in to change notification settings - Fork 34
Y25-286 - Separate accession eligibility from validity #5486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5486 +/- ##
===========================================
- Coverage 87.39% 87.28% -0.12%
===========================================
Files 1457 1457
Lines 32705 32703 -2
Branches 3423 3422 -1
===========================================
- Hits 28584 28545 -39
- Misses 4106 4143 +37
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…m-agressive-validation
9d5b9a4 to
47291b5
Compare
|
Moved later developments into #5499 |
BenTopping
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions, looks good.
Merges into #5491
Changes proposed in this pull request
InternalValidationErrorsif a sample should not be accessionedfor_sample_accessioningwith Railsy model methodsSample is linked to a study that does not require accessioning.Sample is not linked to any studies but must be linked to exactly one study.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version