Y25-286 - Add semantic meaning to data release timings #5491
+33
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrietc52
approved these changes
Jan 26, 2026
Contributor
harrietc52
left a comment
harrietc52
left a comment
There was a problem hiding this comment.
Looks good, just 1 minor comment I think - feel free to ignore.
| validates :data_release_timing, inclusion: { in: DATA_RELEASE_TIMINGS_FOR_OPEN_RELEASE }, | ||
| if: :data_release_timing_must_be_open? | ||
| validates :data_release_timing, inclusion: { in: [DATA_RELEASE_TIMING_NEVER] }, | ||
| if: :data_release_timing_must_be_never? |
Contributor
There was a problem hiding this comment.
Could be worth adding some simple tests for this validation
Contributor
Author
There was a problem hiding this comment.
Thanks for the review 🙂
Validation tests can be found in study_spec.rb - no changes have been made, proving that the existing functionality is untouched.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5491 +/- ##
===========================================
+ Coverage 87.33% 87.38% +0.04%
===========================================
Files 1457 1457
Lines 32701 32703 +2
Branches 3422 3422
===========================================
+ Hits 28561 28577 +16
+ Misses 4125 4111 -14
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring was instrumental in and required for #5486
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version