refactor: make parser tests integration tests#485
refactor: make parser tests integration tests#485kodiakhq[bot] merged 3 commits intosbdchd:masterfrom
Conversation
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
|
I think I copied what rust analyzer is doing with their parser https://github.com/rust-lang/rust-analyzer/tree/master/crates/parser They have:
Meanwhile, ruff https://github.com/astral-sh/ruff/tree/main/crates/ruff_python_parser has:
I like the |
|
I think the biggest difference is that in integration tests, you import the crate and are limited to its public api. I prefer this distinction for tests like we have here, but I will leave the decision up to you :) |
|
@psteinroe ah that makes sense, seems fine to move them to |
can we merge this then? :) |
|
Oops sorry! |
let me know if you want this. I think the separation will be beneficial when I add the regression test suite back.
ref: https://doc.rust-lang.org/rust-by-example/testing/integration_testing.html