Closed
Conversation
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
Owner
|
@psteinroe sorry! I merged the other PR and caused a merge conflict with this one! |
Contributor
Author
no problem - fixed! :) btw - the glob engine of #[dir_test(
dir: "$CARGO_MANIFEST_DIR/tests/data/",
glob: "{ok,err}/*.sql",
)] |
kodiakhq bot
pushed a commit
that referenced
this pull request
May 23, 2025
follow-up for #486 reference: https://www.postgresql.org/docs/current/sql-explain.html > boolean: Specifies whether the selected option should be turned on or off. You can write TRUE, ON, or 1 to enable the option, and FALSE, OFF, or 0 to disable it. The boolean value can also be omitted, in which case TRUE is assumed. makes 5 more regression tests pass 🎉 added one todo item - i was not sure if its possible to know if its specifically 1 or 0. let me know if it is! :)
Owner
|
fyi, I merged the other PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a follow-up for #485
adds an ignored test that runs the parser on the entire regression test suite.
the snapshots are only written for failed tests and into a gitignored directory. the test files are not ignored to not force re-downloading everytime.
this allows a developer to go through the failed snapshots one-by-one and fix the parser.
I also added some logic to the download script to remove template variables because they are not supported (yet).