Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1774 +/- ##
=======================================
Coverage ? 87.67%
=======================================
Files ? 140
Lines ? 12125
Branches ? 0
=======================================
Hits ? 10631
Misses ? 1494
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
manuelgloeckler
approved these changes
Feb 20, 2026
Contributor
manuelgloeckler
left a comment
manuelgloeckler
left a comment
There was a problem hiding this comment.
Great, thanks for fixing.
| ], | ||
| ids=["loop", "scan"], | ||
| ) | ||
| @pytest.mark.parametrize("mode", ["loop", pytest.param("scan")], ids=["loop", "scan"]) |
Contributor
There was a problem hiding this comment.
Shouldnt, we still add an "skip" if e.g. someone uses torch < 2.5 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.