Skip to content

Master#1

Merged
shipdocs merged 3 commits intodevelopfrom
master
Jan 19, 2026
Merged

Master#1
shipdocs merged 3 commits intodevelopfrom
master

Conversation

@shipdocs
Copy link
Owner

@shipdocs shipdocs commented Jan 19, 2026

User description

User description

Description

Rebase

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Performance improvement
  • Code refactoring
  • Documentation update
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issues

Testing

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests for new functionality
  • All tests pass locally
  • No new warnings are generated

Screenshots (if applicable)

Notes for Reviewers


PR Type

Documentation


Description

  • Update Hungarian translations with punctuation and wording improvements

  • Update Chinese (Simplified) translations with terminology and phrasing refinements

  • Remove Kazakh translation file

  • Improve consistency in ellipsis usage and sentence structure


Diagram Walkthrough

flowchart LR
  A["Translation Files"] -->|Hungarian updates| B["i18n/hu/cosmic_store.ftl"]
  A -->|Chinese updates| C["i18n/zh-CN/cosmic_store.ftl"]
  A -->|Remove| D["i18n/kk/cosmic_store.ftl"]
  B -->|Punctuation & wording| E["Updated Translations"]
  C -->|Terminology & phrasing| E
Loading

File Walkthrough

Relevant files
Documentation
cosmic_store.ftl
Hungarian translation punctuation and wording updates       

i18n/hu/cosmic_store.ftl

  • Replace ellipsis with proper Unicode character (… instead of ...)
  • Remove trailing periods from several UI strings for consistency
  • Update "Összes mutatása" to "Összes megjelenítése" for better
    terminology
  • Update "Flathub havi letöltések" to "Havi letöltések a Flathubon" for
    improved phrasing
+15/-15 
cosmic_store.ftl
Chinese (Simplified) translation terminology and phrasing refinements

i18n/zh-CN/cosmic_store.ftl

  • Refine terminology: "小部件" to "小部件", "停靠栏" to "程序坞", "创意" to "创作"
  • Improve phrasing in codec dialog and repository descriptions
  • Update punctuation consistency with proper ellipsis usage
  • Add new translation entries for delete-app-data,
    uninstall-app-flatpak-warning, and version
  • Adjust sentence structure for better readability and natural Chinese
    expression
+27/-24 

Summary by CodeRabbit

  • Documentation
    • Updated Hungarian language translations with improved punctuation standardization and consistent UI messaging across application dialogs and menus
    • Enhanced Simplified Chinese translations for better clarity in codec installation dialogs, navigation items, repository management, and interface labels
    • Added new localization entries and refined existing translations to improve user experience for Hungarian and Simplified Chinese speakers

✏️ Tip: You can customize this high-level summary in your review settings.


CodeAnt-AI Description

Update Hungarian and Simplified Chinese translations; remove Kazakh file

What Changed

  • Hungarian translations: punctuation, ellipsis, and wording adjusted for clearer displayed messages (e.g., buttons, status lines, dialog text)
  • Simplified Chinese translations: wording and phrasing refined for clearer prompts and dialog text; several labels and helper texts revised
  • Removed the Kazakh translation file from the repository

Impact

✅ Clearer Hungarian UI strings
✅ Clearer Simplified Chinese UI strings
✅ Removed obsolete Kazakh translation file

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

weblate and others added 3 commits January 16, 2026 17:23
Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
Co-authored-by: Geeson Wan <wang14240@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: therealmate <hellogaming91@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/pop-os/cosmic-store/hu/
Translate-URL: https://hosted.weblate.org/projects/pop-os/cosmic-store/zh_Hans/
Translation: Pop OS/COSMIC Store
i18n: translation update from Hosted Weblate
@shipdocs shipdocs self-assigned this Jan 19, 2026
@codeant-ai
Copy link

codeant-ai bot commented Jan 19, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Two localization files updated with punctuation standardization and wording refinements. Hungarian translations harmonize ellipsis characters and remove trailing punctuation for consistency. Simplified Chinese translations extensively reword UI strings for clarity and introduce new localization keys.

Changes

Cohort / File(s) Summary
Hungarian Translation Updates
i18n/hu/cosmic_store.ftl
Punctuation harmonization replacing triple dots with single ellipsis character (…); removal of trailing periods from "no-" prefixed keys; minor wording adjustments to UI strings (e.g., see-all, monthly-downloads, codec-related strings, operations-running states, repository dialogs) and phrasing expansions for consistency.
Simplified Chinese Translation Expansion
i18n/zh-CN/cosmic_store.ftl
Extensive rewording for UI clarity across multiple areas: applet placement phrasing, codec dialog simplification, repository/progress dialog adjustments, uninstall confirmation messages, navigation labels (removed game/relax/socialize/utilities items; updated explore/create/work/develop/learn), and app listing language. New keys added (delete-app-data, uninstall-app-flatpak-warning, version) and existing keys updated for consistency (monthly-downloads, licenses, developer references).

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰✨ With ellipsis dots now neat and clean,
And words rewoven, crisp and keen,
We hop through tongues both old and new,
Each translation shining bright and true! 📝

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Master' is generic and does not describe the actual changes (translation updates and file removal) in the pull request. Replace with a descriptive title like 'Update translations and remove Kazakh locale' or 'i18n: update Hungarian and Chinese translations'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description is mostly complete with detailed explanation of changes, though the template sections (Type of Change, Testing, Checklist) are left blank despite the template structure being present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@codeant-ai codeant-ai bot added the size:M This PR changes 30-99 lines, ignoring generated files label Jan 19, 2026
@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
High-level
Incomplete localization for new feature strings

New translation keys like delete-app-data were added to the Chinese localization
file but are missing from other language files. To ensure a consistent user
experience, these new keys should be added to all translation files.

Examples:

i18n/zh-CN/cosmic_store.ftl [145-147]
delete-app-data = 永久移除应用数据
uninstall-app-flatpak-warning = 卸载 { $name } 会保留所有文件和数据。
version = { $version } 版本

Solution Walkthrough:

Before:

// File: 'i18n/zh-CN/cosmic_store.ftl'
...
view-more = 查看更多
+delete-app-data = 永久移除应用数据
+uninstall-app-flatpak-warning = 卸载 { $name } 会保留所有文件和数据。
+version = { $version } 版本

// File: 'i18n/hu/cosmic_store.ftl'
...
recommended-flatpak-sources = Ajánlott Flatpak-források
// New keys are missing at the end of the file.

After:

// File: 'i18n/zh-CN/cosmic_store.ftl'
...
view-more = 查看更多
delete-app-data = 永久移除应用数据
uninstall-app-flatpak-warning = 卸载 { $name } 会保留所有文件和数据。
version = { $version } 版本

// File: 'i18n/hu/cosmic_store.ftl'
...
recommended-flatpak-sources = Ajánlott Flatpak-források
...
+delete-app-data = Permanently remove app data
+uninstall-app-flatpak-warning = Uninstalling { $name } will preserve all files and data.
+version = Version { $version }
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies a critical oversight where new translation keys are added to only one language file, which will lead to a broken user experience in other languages.

High
General
Use Unicode ellipsis

For consistency, replace the three-dot ellipsis (...) with the Unicode ellipsis
character () in the adding, removing, and operations-running-finished
translation keys.

i18n/zh-CN/cosmic_store.ftl [38-51]

-adding = 正在添加...
-removing = 正在移除...
-operations-running-finished = { $running } 个操作正在运行({ $percent }%),{ $finished } 个已完成...
+adding = 正在添加…
+removing = 正在移除…
+operations-running-finished = { $running } 个操作正在运行({ $percent }%),{ $finished } 个已完成…

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the PR missed updating several keys (adding, removing, operations-running-finished) to use the Unicode ellipsis (), which improves consistency with other changes in the file.

Low
Remove space before punctuation

In the codec-header translation, remove the space before the full stop to
correct the punctuation.

i18n/zh-CN/cosmic_store.ftl [25]

-codec-header = "{ $application }" 需要额外的软件包来提供 "{ $description }" 。
+codec-header = "{ $application }" 需要额外的软件包来提供 "{ $description }"。
  • Apply / Chat
Suggestion importance[1-10]: 4

__

Why: The suggestion correctly points out a minor punctuation error (a space before a full stop) introduced in the PR, which is incorrect in Chinese typography.

Low
  • More

@shipdocs shipdocs merged commit fda4972 into develop Jan 19, 2026
2 of 3 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@i18n/zh-CN/cosmic_store.ftl`:
- Around line 37-38: The two message keys operations-running and
operations-running-finished use inconsistent ellipsis characters; standardize
them by choosing one style (prefer Unicode ellipsis '…' for consistency) and
update the string for operations-running-finished to use the same ellipsis
character as operations-running so both keys (operations-running,
operations-running-finished) display identical ellipsis formatting.

Comment on lines +37 to 38
operations-running = { $running } 个操作正在运行({ $percent }%)
operations-running-finished = { $running } 个操作正在运行({ $percent }%),{ $finished } 个已完成...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor inconsistency in ellipsis usage.

Line 37 uses a Unicode ellipsis while line 38 uses three ASCII dots .... Consider harmonizing to use the same style for consistency.

Suggested fix
 operations-running = { $running } 个操作正在运行({ $percent }%)…
-operations-running-finished = { $running } 个操作正在运行({ $percent }%),{ $finished } 个已完成...
+operations-running-finished = { $running } 个操作正在运行({ $percent }%),{ $finished } 个已完成…
🤖 Prompt for AI Agents
In `@i18n/zh-CN/cosmic_store.ftl` around lines 37 - 38, The two message keys
operations-running and operations-running-finished use inconsistent ellipsis
characters; standardize them by choosing one style (prefer Unicode ellipsis '…'
for consistency) and update the string for operations-running-finished to use
the same ellipsis character as operations-running so both keys
(operations-running, operations-running-finished) display identical ellipsis
formatting.

@codeant-ai
Copy link

codeant-ai bot commented Jan 19, 2026

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Possible semantic error
    The Flatpak uninstall warning states "卸载 { $name } 会保留所有文件和数据。" — double-check the intended behavior. It currently asserts that uninstall will keep all files/data; if the implementation actually removes or keeps data, the message should be adjusted to avoid misleading users.

  • Pluralization
    Several user-facing strings that include numeric counts (e.g. running operations) are written as a single phrase without plural/select handling. This can produce grammatically incorrect Hungarian when the count is 0, 1, or >1. Use Fluent plural/select constructs so singular/plural/zero forms are correct and natural.

  • Selection block formatting
    The repository remove message uses a select/variant block that was changed; the '*[other]' variant line ends with '以及' and the closing/continuation might be misaligned. Verify the Fluent select block renders the intended text and doesn't accidentally break the sentence structure.

@codeant-ai
Copy link

codeant-ai bot commented Jan 19, 2026

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review effort 1/5 size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants