Skip to content

Enable test/analysis_options.yaml (issue #192) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xJac0b wants to merge 2 commits into from
Closed

Enable test/analysis_options.yaml (issue #192) #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a13a9
fix: respect test/analysis_options.yaml
xJac0b Jun 6, 2025
5ce3bdb
fix: Revert single number change
xJac0b Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ And then include `solid_lints` into your project top-level `analysis_options.yam

```yaml
include: package:solid_lints/analysis_options.yaml

analyzer:
plugins:
- custom_lint
```
> Add `custom_lint` under `analyzer.plugins` to enable lint rules.


Also you can use a specialized rule set designed for Dart tests.
Add an `analysis_options.yaml` file under the `test/` directory, and include the ruleset:
Expand Down
2 changes: 0 additions & 2 deletions lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
analyzer:
plugins:
- custom_lint
Comment on lines -2 to -3
Copy link
Collaborator

@solid-vovabeloded solid-vovabeloded Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should change analysis_options.yaml here. The issue is about the analysis_options_test.yaml and its setup to work only for the test package of the end users.

exclude:
# General generated files
- '**/*.g.dart'
Expand Down