Upgrade numba version to support python 3.12#41
Conversation
MatteoGiomi
left a comment
There was a problem hiding this comment.
Thanks @danclaytondev for taking care of this! Feel free to merge this PR!
|
Hi @danclaytondev, do you need help with this? |
ff0b33d to
78fd440
Compare
|
Hi @MatteoGiomi sorry I left this for a while, I've updated the type hints to remove deprecated usage (now that we aren't supporting 3.8, ruff will not let us use them). |
|
@danclaytondev it seems that there is some incompatibility between pandas and numpy. Probably installing a lower version of the latter would solve the problem. |
|
Thanks a lot @danclaytondev for this PR, I fixed the CI by capping the numpy version and it works ok now. I'll merge it! |
|
Hi @MatteoGiomi thanks very much for picking this up, and apologies that I left it for so long unresolved. Cheers! |
Thanks to your work, I had very little left to do. I wanted to merge this because another PR was waiting and didn't want to leave the rebase to this one. They are always fun. |
It would be great to run Anonymeter with Python 3.12.
It was previously constrained by numba python support, so this is a fairly conservative update from numba 0.58 to 0.59 which moves anonymeter support to <=3.9, <3.13.
Python 3.8 is already end of life so I don't think new versions of Anonymeter need to be supporting anything lower than 3.9.
I have left other dependency versions the same.
Tests passing on 3.12: