Conversation
WalkthroughThis change updates the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/`@tailwindcss-upgrade/package.json:
- Line 35: The globby v16 change affects the call in
packages/@tailwindcss-upgrade/src/index.ts where globby is invoked with the
option gitignore: true (around the call site passing that option); test the repo
with globby v16 to confirm whether parent .gitignore rules now exclude files you
expect to include; if the behavior is unacceptable either (A) adjust the globby
call to gitignore: false and add explicit ignore/include patterns to replicate
the previous behavior, or (B) pin globby to v15 in package.json, or (C) update
the code to compute a custom ignore list that merges only the .gitignore files
you want—run unit/integration tests and update snapshots accordingly before
merging.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/@tailwindcss-upgrade/package.json
| "dedent": "1.7.1", | ||
| "enhanced-resolve": "^5.19.0", | ||
| "globby": "^15.0.0", | ||
| "globby": "^16.1.1", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find the `@tailwindcss-upgrade` package directory
UPGRADE_PKG="packages/@tailwindcss-upgrade"
# 1) Find all globby imports and usages in the `@tailwindcss-upgrade` package
echo "=== Globby imports in `@tailwindcss-upgrade` ==="
rg -n --type=ts --type=js 'globby|isGitIgnored' "$UPGRADE_PKG" || echo "No matches found"
echo ""
echo "=== Globby function calls with options ==="
rg -n -B2 -A4 'globby\s*\(' "$UPGRADE_PKG" || echo "No matches found"
echo ""
echo "=== Gitignore option usage ==="
rg -n -C3 'gitignore\s*:' "$UPGRADE_PKG" || echo "No matches found"
echo ""
echo "=== Negation pattern usage ==="
rg -n -C3 '!\s*["\']|expandNegationOnlyPatterns' "$UPGRADE_PKG" || echo "No matches found"Repository: tailwindlabs/tailwindcss
Length of output: 2013
🌐 Web query:
globby v16 breaking changes release notes
💡 Result:
globby v16.0.0 — breaking change (release date: 2025-11-15)
gitignore: truenow respects parent.gitignorefiles up to the Git repo root (when a repo is detected). Previously, globby only considered.gitignorefiles within the glob search path, so results may now exclude additional files/directories due to inherited ignore rules. [1][2]
Release notes / changelog: [1]
Sources
- [1] GitHub release: globby
v16.0.0notes (Breaking/Improvements/Fixes) - [2] globby README (
gitignoreoption behavior description)
Test globby v16 upgrade before merging—breaking change in gitignore behavior confirmed.
Line 99 in packages/@tailwindcss-upgrade/src/index.ts uses gitignore: true, which has a breaking behavioral change in v16: parent .gitignore files up to the Git repo root are now respected, whereas v15 only considered .gitignore files within the search path. This means file discovery in @tailwindcss/upgrade will now exclude additional files/directories inherited from parent ignore rules. Verify through testing that this new behavior is acceptable (e.g., files in subdirectories with upstream .gitignore rules are no longer unexpectedly included).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/`@tailwindcss-upgrade/package.json at line 35, The globby v16 change
affects the call in packages/@tailwindcss-upgrade/src/index.ts where globby is
invoked with the option gitignore: true (around the call site passing that
option); test the repo with globby v16 to confirm whether parent .gitignore
rules now exclude files you expect to include; if the behavior is unacceptable
either (A) adjust the globby call to gitignore: false and add explicit
ignore/include patterns to replicate the previous behavior, or (B) pin globby to
v15 in package.json, or (C) update the code to compute a custom ignore list that
merges only the .gitignore files you want—run unit/integration tests and update
snapshots accordingly before merging.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ globby (15.0.0 → 16.1.1) · Repo
Release Notes
16.1.1
16.1.0
16.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 27 commits:
16.1.1Fix negation patterns with absolute filesystem paths16.1.0Add `expandNegationOnlyPatterns` optionFix: Normalize leading-slash negation patterns before task generation16.0.0Fix bundler compatibilityRespect parent .gitignore files when `gitignore` option is enabledAdd test for `suppressErrors` option with file patternsAdd test for ignore option with trailing slashesFix parent directory patterns with `gitignore` optionAdd tests for special characters in directory namesImprove path check in gitignore logicImprove error message for invalid `cwd` optionFix types for `stats` optionFix ignore patterns with parent directory referencesImprove Windows path documentationSupport negation-only patternsRespect custom fs implementation from optionsImprove docs for `convertPathToPattern`Add test for .npmignore in subdirectoriesClarify `gitignore` priority in documentationAdd test for nested gitignore with negationAdd some more options to isGitIgnored functionsFix `{gitignore: true}` performance issueAdd tests for some fast-glob limitationsAdd test for gitignore patterns starting with `./` or `../`Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands