Skip to content

Update globby 15.0.0 → 16.1.1 (major) #19724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
depfu wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −18
Open

Update globby 15.0.0 → 16.1.1 (major) #19724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@tailwindcss-upgrade/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"braces": "^3.0.3",
"dedent": "1.7.1",
"enhanced-resolve": "^5.19.0",
"globby": "^15.0.0",
"globby": "^16.1.1",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find the `@tailwindcss-upgrade` package directory
UPGRADE_PKG="packages/@tailwindcss-upgrade"

# 1) Find all globby imports and usages in the `@tailwindcss-upgrade` package
echo "=== Globby imports in `@tailwindcss-upgrade` ==="
rg -n --type=ts --type=js 'globby|isGitIgnored' "$UPGRADE_PKG" || echo "No matches found"

echo ""
echo "=== Globby function calls with options ==="
rg -n -B2 -A4 'globby\s*\(' "$UPGRADE_PKG" || echo "No matches found"

echo ""
echo "=== Gitignore option usage ==="
rg -n -C3 'gitignore\s*:' "$UPGRADE_PKG" || echo "No matches found"

echo ""
echo "=== Negation pattern usage ==="
rg -n -C3 '!\s*["\']|expandNegationOnlyPatterns' "$UPGRADE_PKG" || echo "No matches found"

Repository: tailwindlabs/tailwindcss

Length of output: 2013

🌐 Web query:

globby v16 breaking changes release notes

💡 Result:

globby v16.0.0 — breaking change (release date: 2025-11-15)

  • gitignore: true now respects parent .gitignore files up to the Git repo root (when a repo is detected). Previously, globby only considered .gitignore files within the glob search path, so results may now exclude additional files/directories due to inherited ignore rules. [1][2]

Release notes / changelog: [1]

Sources

  • [1] GitHub release: globby v16.0.0 notes (Breaking/Improvements/Fixes)
  • [2] globby README (gitignore option behavior description)

Test globby v16 upgrade before merging—breaking change in gitignore behavior confirmed.

Line 99 in packages/@tailwindcss-upgrade/src/index.ts uses gitignore: true, which has a breaking behavioral change in v16: parent .gitignore files up to the Git repo root are now respected, whereas v15 only considered .gitignore files within the search path. This means file discovery in @tailwindcss/upgrade will now exclude additional files/directories inherited from parent ignore rules. Verify through testing that this new behavior is acceptable (e.g., files in subdirectories with upstream .gitignore rules are no longer unexpectedly included).

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/`@tailwindcss-upgrade/package.json at line 35, The globby v16 change
affects the call in packages/@tailwindcss-upgrade/src/index.ts where globby is
invoked with the option gitignore: true (around the call site passing that
option); test the repo with globby v16 to confirm whether parent .gitignore
rules now exclude files you expect to include; if the behavior is unacceptable
either (A) adjust the globby call to gitignore: false and add explicit
ignore/include patterns to replicate the previous behavior, or (B) pin globby to
v15 in package.json, or (C) update the code to compute a custom ignore list that
merges only the .gitignore files you want—run unit/integration tests and update
snapshots accordingly before merging.

"jiti": "^2.0.0-beta.3",
"mri": "^1.2.0",
"picocolors": "^1.1.1",
Expand Down
34 changes: 17 additions & 17 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading