feat: Switch from Sentry xcframework to SentrySPM compile-from-source#92
Merged
feat: Switch from Sentry xcframework to SentrySPM compile-from-source#92
Conversation
Migrate all imports from `import Sentry` and `import SentrySwiftUI` to `import SentrySPM`, which compiles Sentry directly from source via SPM. This uses the new SentrySPM product from getsentry/sentry-cocoa that re-exports both the ObjC and Swift modules through a single import. Updated Xcode project references and Package.resolved to point to the philprime/spm-sample branch of sentry-cocoa.
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the iOS app and share extension from the Sentry xcframework/SentrySwiftUI modules to the new compile-from-source SwiftPM product (SentrySPM), consolidating usage under a single import SentrySPM.
Changes:
- Updated Swift sources to replace
import Sentry/import SentrySwiftUIwithimport SentrySPM. - Updated Xcode project SwiftPM package/product wiring to use the
sentry-cocoaphilprime/spm-samplebranch/product. - Updated dependency resolution + Settings.bundle license outputs to reflect the new Sentry package source.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Targets/ShareExtension/Sources/ShareViewController.swift | Switch Sentry import to SentrySPM in the share extension. |
| Targets/App/Sources/Utils/SentryMetricsHelper.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/UI/MainContainerView.swift | Switch SentrySwiftUI import to SentrySPM. |
| Targets/App/Sources/UI/LinkLists/LinkListsContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/LinkListInfo/LinkListInfoContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/LinkListDetail/LinkListDetailContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/LinkInfo/LinkInfoContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/LinkDetailNFCSharing/LinkDetailNFCSharingViewModel.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/UI/LinkDetailNFCSharing/LinkDetailNFCSharingContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/LinkDetail/LinkDetailRenderView.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/UI/LinkDetail/LinkDetailContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/CreateListEditor/CreateLinkListEditorContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/CreateLinkWithoutListEditor/LinkListPickerContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/CreateLinkWithoutListEditor/CreateLinkWithListPickerEditorContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/UI/CreateLinkEditor/CreateLinkEditorContainerView.swift | Consolidate Sentry imports to SentrySPM. |
| Targets/App/Sources/Services/QRCodeCache.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/Services/DataSeedingService.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/Services/AppHealthObserver.swift | Switch Sentry import to SentrySPM. |
| Targets/App/Sources/Resources/Settings.bundle/Licenses.plist | Update displayed Sentry license entry title. |
| Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt | Regenerated license-plist output; Sentry version now blank due to branch-based dependency. |
| Targets/App/Sources/Main/FlinkyApp.swift | Switch Sentry import to SentrySPM. |
| Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Pin sentry-cocoa to a branch + revision; updated another package revision. |
| Flinky.xcodeproj/project.pbxproj | Replace Sentry products with SentrySPM and update SwiftPM package reference/requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Flinky.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Targets/App/Sources/Resources/Settings.bundle/Licenses.latest_result.txt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import Sentry/import SentrySwiftUItoimport SentrySPM, using the new compile-from-source SPM product from getsentry/sentry-cocoa#7430Package.resolvedto point to thephilprime/spm-samplebranch of sentry-cocoaimport SentrySPMTest plan
make build-iosOnce feat: Add SentrySPM compile-from-source product and multi-platform sample apps getsentry/sentry-cocoa#7430 is merged, update Package.resolved to point to the merged commit/tag