Add test for multi-op err with resource exhausted #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
approved these changes
Jan 23, 2026
Contributor
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
Always love more tests 😃
| opErrors := multiOp.OperationErrors() | ||
| require.Len(t, opErrors, 2) | ||
|
|
||
| // Verify the first error is ResourceExhausted with preserved details |
Contributor
There was a problem hiding this comment.
Would we care to also verify the InvalidArgument survives the round trip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a test to verify that
serviceeerror.MultiOperationExecutionErrorretains theserviceerror.ResourceExhaustedcause, scope, and details.Why?
Validation
How did you test it?
Only a test
Potential risks
None