Skip to content

Add test for multi-op err with resource exhausted #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spkane31 merged 3 commits into from
Jan 23, 2026
Merged

Add test for multi-op err with resource exhausted #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6544f17
Add test for multi-op err with resource exhausted
spkane31 Jan 23, 2026
607623a
validate second error
spkane31 Jan 23, 2026
f5beec5
Merge branch 'master' into spk/update-w-start-error
spkane31 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions serviceerror/convert_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"google.golang.org/protobuf/types/known/anypb"
"google.golang.org/protobuf/types/known/durationpb"

enumspb "go.temporal.io/api/enums/v1"
"go.temporal.io/api/errordetails/v1"
"go.temporal.io/api/serviceerror"
)
Expand Down Expand Up @@ -133,6 +134,48 @@ func TestMultiOperationExecution(t *testing.T) {
})
}

func TestMultiOperationExecution_PreservesResourceExhaustedDetails(t *testing.T) {
resourceErr := &serviceerror.ResourceExhausted{
Cause: enumspb.RESOURCE_EXHAUSTED_CAUSE_RPS_LIMIT,
Scope: enumspb.RESOURCE_EXHAUSTED_SCOPE_NAMESPACE,
Message: "rate limit exceeded",
}
multiErr := serviceerror.NewMultiOperationExecution(
"multi-op failed",
[]error{
resourceErr,
serviceerror.NewInvalidArgument("other error"),
},
)

// Check round-trip conversion
st := serviceerror.ToStatus(multiErr)
reconstructed := serviceerror.FromStatus(st)

multiOp, ok := reconstructed.(*serviceerror.MultiOperationExecution)
require.True(t, ok)

// Get the operation errors
opErrors := multiOp.OperationErrors()
require.Len(t, opErrors, 2)

// Verify the first error is ResourceExhausted with preserved details
Copy link
Contributor

@yuandrew yuandrew Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we care to also verify the InvalidArgument survives the round trip?

reErr, ok := opErrors[0].(*serviceerror.ResourceExhausted)
require.True(t, ok)
require.Equal(t, enumspb.RESOURCE_EXHAUSTED_CAUSE_RPS_LIMIT, reErr.Cause)
require.Equal(t, enumspb.RESOURCE_EXHAUSTED_SCOPE_NAMESPACE, reErr.Scope)
require.Equal(t, "rate limit exceeded", reErr.Message)

// Verify the second error is InvalidArgument with preserved details
invErr, ok := opErrors[1].(*serviceerror.InvalidArgument)
require.True(t, ok)
require.Equal(t, "other error", invErr.Message)

// Verify proto round-trip equality
reconstructedStatus := serviceerror.ToStatus(reconstructed)
require.True(t, proto.Equal(st.Proto(), reconstructedStatus.Proto()))
}

func TestMultiOperationAborted(t *testing.T) {
err := serviceerror.NewMultiOperationAborted("Operation was aborted.")

Expand Down