block per-ns-tq from external users - workflow section #9126
+730
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiyang3cat
force-pushed
the
feat/block-per-ns-tq-workflow
branch
from
4080986 to
8e61b58
Compare
feiyang3cat
changed the title
5 tasks
feiyang3cat
commented
Jan 23, 2026
| } | ||
|
|
||
| func (pm *taskQueuePartitionManagerImpl) ephemeralDataChanged(data *taskqueuespb.EphemeralData) { | ||
| // for now, only sticky partitions act on ephemeral data, normal partitions ignore it. |
Contributor
Author
There was a problem hiding this comment.
this change is only for lint purpose
yycptt
reviewed
Jan 26, 2026
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.go
Outdated
Show resolved
Hide resolved
feiyang3cat
force-pushed
the
feat/block-per-ns-tq-workflow
branch
5 times, most recently
from
fc600a2 to
3cb1eca
Compare
feiyang3cat
commented
Jan 26, 2026
| wtFailedCause enumspb.WorkflowTaskFailedCause, | ||
| err error, | ||
| ) error { | ||
|
|
feiyang3cat
force-pushed
the
feat/block-per-ns-tq-workflow
branch
from
3cb1eca to
270056b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
block external users using internal temporal-sys-per-ns-tq workers through triggering workflows
Why?
enhanced resilience of the cluster
Detailed Explanation
What is not covered
What is covered
How did you test it?
Potential risks
side-effects on legal system workflows/activities -> covered by regression testing (either unit or functional)