Merged
Conversation
Signed-off-by: fredchenbj <cfworking@163.com>
Connor1996
reviewed
Dec 17, 2019
librocksdb_sys/build.rs
Outdated
| // Other platforms use bindgen to generate the bindings every time. | ||
| fn config_binding_path() { | ||
| let file_path: PathBuf; | ||
| println!("cargo:rerun-if-changed=bindings/x86_64-unknown-linux-gnu-bindings.rs"); |
Member
There was a problem hiding this comment.
Please add cargo:rerun-if-env-changed=UPDATE_BIND, and remove this cause it will forbid rerun when other files changed in librocksdb_sys/*
Member
|
Sorry for the late review, LGTM overall |
Signed-off-by: fredchenbj <cfworking@163.com>
Collaborator
|
/run-all-tests |
yiwu-arbug
reviewed
Dec 19, 2019
| [build-dependencies] | ||
| cc = "1.0.3" | ||
| cmake = "0.1" | ||
| bindgen = "0.52" |
Collaborator
There was a problem hiding this comment.
seems bindgen 0.52 is conflicting with grpcio, which is using bindgen 0.51. Any thoughts on how to fix?
Member
Author
There was a problem hiding this comment.
use bindgen 0.51 to fix it ?
daverigby
pushed a commit
to daverigby/rust-rocksdb
that referenced
this pull request
May 9, 2025
Advance the pinned SHA of the rocksdb submodule to the latest commit on the 6.29.tikv branch. This brings in the following commits vs previous pinned SHA (HEAD): ``` * 698e71d45 2025-05-08 | Cherry-pick compilation fix (tikv#410) (origin/6.29.tikv) [Yang Zhang] * c52cd52b7 2025-01-20 | [CP-to-6.29.tikv] rate-limiter: fix clock skew if enabling auto-tuned. (tikv#401) (tikv#402) [lucasliang] * ee26b5cba 2024-09-09 | OWNERS: Auto Sync OWNERS files from community membership (tikv#371) [Ti Chi Robot] * b1cd552a4 2024-08-30 | [skip ci] Update OWNERS file (tikv#366) [Ti Chi Robot] * 3fe3ffaab 2024-07-25 | Fix bloom filter compatibility issue caused by naming (tikv#365) [Yang Zhang] * 45509f0f5 2024-03-26 | Ensure writes to WAL tail during `FlushWAL(true /* sync */)` will be synced (#10560) (tikv#357) [Connor] * 3dba9fa20 2024-02-01 | Add a blob-specific cache priority (#10461) (tikv#354) [Connor] * dcf2f8d56 2024-01-03 | Add copy constructor to ColumnFamilyHandleImpl (tikv#353) [Yang Zhang] * 938c01617 2023-10-09 | fix new write amp io-limiter (tikv#350) [glorv] * 0813e37a4 2023-10-09 | fix deadlock between Flush and UnregisterDB (tikv#349) [Spade A] * c0953b3c0 2023-09-21 | make WriteAmpBasedRateLimiter's auto tune smooth window configurable (tikv#348) [glorv] * 20225a41c 2023-09-09 | Avoid chaos between NotifyOnMemTableSealed and NotifyOnFlushCompleted (tikv#347) (HEAD) [Spade A] ``` Noteworthy changes affecting our use of tikv/rocksdb: * Fixed bug where `FlushWAL(true /* sync */)` (used by `GetLiveFilesStorageInfo()`, which is used by checkpoint and backup) could cause parallel writes at the tail of a WAL file to never be synced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is extraced from pr #398 to make code review easier.
Like grpc-rs pr tikv/grpc-rs#356, this pr pre-generate the bindings. Later, I would finish pr #398 based on this pre-generated bindings.
Signed-off-by: fredchenbj cfworking@163.com