Move MsgSubmitProposal of group module to non-determinstic gas#104
Open
Move MsgSubmitProposal of group module to non-determinstic gas#104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the deterministic gas configuration for group messages by moving
MsgWithdrawProposalfrom the deterministic to the non-deterministic category. This change ensures more consistent gas estimation logic for proposal-related messages and updates the associated tests to reflect the new categorization.Changes to gas configuration logic:
MsgWithdrawProposalfrom the deterministic gas mapping inDefaultConfig, so it no longer uses a fixed gas value.MsgWithdrawProposalto the list of non-deterministic messages inDefaultConfig, aligning its treatment with other proposal-related messages.Test updates:
TestDeterministicGas_DeterministicMessagesto reflect the new counts: increased non-deterministic messages by one and decreased deterministic messages by one.Reviewers checklist:
Authors checklist
This change is