Skip to content

Move MsgSubmitProposal of group module to non-determinstic gas #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TxCorpi0x wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Move MsgSubmitProposal of group module to non-determinstic gas #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x/deterministicgas/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ func DefaultConfig() Config {
MsgToMsgURL(&group.MsgUpdateGroupPolicyAdmin{}): constantGasFunc(20_000),
MsgToMsgURL(&group.MsgUpdateGroupPolicyDecisionPolicy{}): constantGasFunc(17_000),
MsgToMsgURL(&group.MsgUpdateGroupPolicyMetadata{}): constantGasFunc(15_000),
MsgToMsgURL(&group.MsgWithdrawProposal{}): constantGasFunc(22_000),
MsgToMsgURL(&group.MsgLeaveGroup{}): constantGasFunc(17_500),

// nft
Expand Down Expand Up @@ -266,6 +265,7 @@ func DefaultConfig() Config {
// For MsgSubmitProposal we have access to the list of messages but estimation depends on Exec attribute
// value that is why we decided to make it non-deterministic to simple logic and consistent with other 2.
&group.MsgSubmitProposal{},
&group.MsgWithdrawProposal{},
&group.MsgVote{},
&group.MsgExec{},

Expand Down
4 changes: 2 additions & 2 deletions x/deterministicgas/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ func TestDeterministicGas_DeterministicMessages(t *testing.T) {
// To make sure we do not increase/decrease deterministic and extension types accidentally,
// we assert length to be equal to exact number, so each change requires
// explicit adjustment of tests.
assert.Equal(t, 95, nondeterministicMsgCount)
assert.Equal(t, 68, deterministicMsgCount)
assert.Equal(t, 96, nondeterministicMsgCount)
assert.Equal(t, 67, deterministicMsgCount)
assert.Equal(t, 12, extensionMsgCount)
assert.Equal(t, 151, nonExtensionMsgCount)
}
Expand Down
Loading