Skip to content

Feat/same net merge#99

Open
gustavo-keiller wants to merge 6 commits intotscircuit:mainfrom
gustavo-keiller:feat/same-net-merge
Open

Feat/same net merge#99
gustavo-keiller wants to merge 6 commits intotscircuit:mainfrom
gustavo-keiller:feat/same-net-merge

Conversation

@gustavo-keiller
Copy link

Merge near-parallel straight trace segments that belong to the same net by aligning them to a common (median) coordinate. This reduces schematic visual clutter while preserving connectivity. Operates on a cloned trace set and is idempotent
/claim #29

@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
schematic-trace-solver Ready Ready Preview Comment Dec 9, 2025 1:48am

@RaghavArora14
Copy link

hey just to inform you the bounty program's been closed as of now you are open to contribute to recent issues tho.

@gustavo-keiller
Copy link
Author

Thanks for the heads-up! Just out of curiosity, where did you find out that the program is closed? I'm new to Algora bounties and thought this one would be a good place to start, so I must have missed the announcement.

@gustavo-keiller
Copy link
Author

@seveibar does this also close the #34 issue ?

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for us to review this you would need to have at the very least some before/after snapshot tests

@gustavo-keiller
Copy link
Author

gustavo-keiller commented Dec 8, 2025

sorry, i posted it on the issue section.
is this enough ?
i'll add them to the project shortly.

before
Old

after
New

@gustavo-keiller
Copy link
Author

gustavo-keiller commented Dec 9, 2025

I attempted to find more examples on the tscircuit website to reproduce the bug but had limited success, so I based my test on the initial image provided in the issue

Copy link
Author

@gustavo-keiller gustavo-keiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other tests showed no significant changes, I created a new test case. I committed the baseline snapshot first, followed by the updated snapshot in different commits.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main problem I'm trying to solve, is there something else my PR is missing ? i'm kind of new here but still want to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants