Adjust safeinput to accept complex URLs in redirect_url value#417
Merged
jonasbardino merged 1 commit intonextfrom Jan 27, 2026
Merged
Conversation
jonasbardino
added a commit
that referenced
this pull request
Jan 26, 2026
…any other changes as seen in #417.
Contributor
Author
|
The lint error in GH actions here were from the unrelated issue now fixed by #419 . |
jonasbardino
added a commit
that referenced
this pull request
Jan 27, 2026
…any other changes as seen in #417.
jonasbardino
added a commit
that referenced
this pull request
Jan 27, 2026
…any other changes as seen in #417.
…r to allow e.g. our own use of Tra URLs with '@' in them when we hit twofactor redirect. Added a series of unit tests to cover the URL validators while at it.
dd5ef41 to
f841b0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust safeinput to accept complex URLs in redirect_url value in order to allow e.g. our own use of Trac URLs with '@' in them when we hit twofactor redirect.
Added a series of unit tests to cover the URL validators while at it.