Skip to content

Adjust safeinput to accept complex URLs in redirect_url value#417

Merged
jonasbardino merged 1 commit intonextfrom
fix/redirect-url-rejected-for-trac-wiki-addresses
Jan 27, 2026
Merged

Adjust safeinput to accept complex URLs in redirect_url value#417
jonasbardino merged 1 commit intonextfrom
fix/redirect-url-rejected-for-trac-wiki-addresses

Conversation

@jonasbardino
Copy link
Contributor

Adjust safeinput to accept complex URLs in redirect_url value in order to allow e.g. our own use of Trac URLs with '@' in them when we hit twofactor redirect.

Added a series of unit tests to cover the URL validators while at it.

@jonasbardino jonasbardino self-assigned this Jan 26, 2026
@jonasbardino jonasbardino added the bug Something isn't working label Jan 26, 2026
@jonasbardino jonasbardino linked an issue Jan 26, 2026 that may be closed by this pull request
jonasbardino added a commit that referenced this pull request Jan 26, 2026
@jonasbardino
Copy link
Contributor Author

jonasbardino commented Jan 26, 2026

The lint error in GH actions here were from the unrelated issue now fixed by #419 .

@jonasbardino jonasbardino marked this pull request as ready for review January 26, 2026 12:43
@jonasbardino jonasbardino requested a review from a team January 26, 2026 12:43
jonasbardino added a commit that referenced this pull request Jan 27, 2026
jonasbardino added a commit that referenced this pull request Jan 27, 2026
…r to allow

e.g. our own use of Tra URLs with '@' in them when we hit twofactor redirect.
Added a series of unit tests to cover the URL validators while at it.
@jonasbardino jonasbardino force-pushed the fix/redirect-url-rejected-for-trac-wiki-addresses branch from dd5ef41 to f841b0f Compare January 27, 2026 12:29
Copy link
Contributor

@Martin-Rehr Martin-Rehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbardino jonasbardino merged commit 0a4a822 into next Jan 27, 2026
7 checks passed
@jonasbardino jonasbardino deleted the fix/redirect-url-rejected-for-trac-wiki-addresses branch January 27, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Our twofactor redirect fails for Trac URLs with @ in them

2 participants