Eliminate PY2 legacy from safeinput where it causes lint errors#419
Conversation
albu-diku
left a comment
There was a problem hiding this comment.
I thikn really we ought to have just done a big sweep for these - remove the constant that is backing all these conditionals, chase down the all he places that import them and axe the lot.
Otherwise given these lint checks run on what has changed we are going to keep on hitting these cases and I think it will be quire painful to address these one by one. I had (maybe have) a branch started locally to do just that but wasn't able to get through chasing it all down when I attempted that.
I won't hold this up, hence the approval, but still think it would be better to just get rid of this stuffonce and for all now it is not needed as compared to a series of such commits.
I don't disagree but I needed the specific fix for the PR. So I also won't object if anyone takes on the task or eliminating all with proper regression testing :-) The list looks rather short for the but there may be more cases e.g. using |
…any other changes as seen in #417.
ed431fe to
67c8adf
Compare
|
Made a start on that - see #425. |
Eliminate
PY2legacy fromsafeinputwhere it causes lint errors upon any other changes as seen in #417 .