Skip to content

‼️ Make need fields added by services nullable and default to null#1644

Merged
chrisjsewell merged 2 commits intomasterfrom
service-fields
Feb 9, 2026
Merged

‼️ Make need fields added by services nullable and default to null#1644
chrisjsewell merged 2 commits intomasterfrom
service-fields

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 9, 2026

Rather than non-nullable and default to empty string.

Note, this could be breaking, for need filters that assume a service field value is always a string.

Rather than non-nullable and default to empty string
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.80%. Comparing base (4e10030) to head (e4620bf).
⚠️ Report is 238 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1644      +/-   ##
==========================================
+ Coverage   86.87%   88.80%   +1.92%     
==========================================
  Files          56       70      +14     
  Lines        6532     9986    +3454     
==========================================
+ Hits         5675     8868    +3193     
- Misses        857     1118     +261     
Flag Coverage Δ
pytests 88.80% <100.00%> (+1.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell chrisjsewell changed the title ⚠️ Make need fields added by services nullable and default to null ‼️ Make need fields added by services nullable and default to null Feb 9, 2026
@chrisjsewell chrisjsewell merged commit 16767e0 into master Feb 9, 2026
22 checks passed
@chrisjsewell chrisjsewell deleted the service-fields branch February 9, 2026 10:36
chrisjsewell added a commit that referenced this pull request Feb 9, 2026
This stops user set defaults from being checked against schema.
As can be seen in this PR, this does not actually break any tests,
principally due to the preceding #1644 and #1645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants