Skip to content

fix: simplify domain verification emails#376

Merged
KMKoushik merged 1 commit intomainfrom
fix/domain-notification-copy
Mar 13, 2026
Merged

fix: simplify domain verification emails#376
KMKoushik merged 1 commit intomainfrom
fix/domain-notification-copy

Conversation

@KMKoushik
Copy link
Member

@KMKoushik KMKoushik commented Mar 13, 2026

Summary

  • remove verification error details from domain verification notification emails
  • keep the success/failure copy focused on whether the domain is verified or needs DNS fixes
  • update both HTML and plain-text notification content paths

Verification

  • pnpm --filter web exec vitest run -c vitest.unit.config.ts src/server/service/domain-service.unit.test.ts src/server/jobs/domain-verification-job.unit.test.ts

Summary by cubic

Simplified domain verification emails by removing verbose error details and focusing the message on success or required DNS fixes. Updated both HTML and plain-text templates and the service to drop verificationError.

  • Refactors
    • Removed verificationError prop and error block from DomainVerificationStatusEmail.
    • Dropped verificationError parameter and usage in sendDomainStatusNotification.
    • Kept clear status message and link to domain settings.

Written for commit b877c8a. Summary will update on new commits.

Summary by CodeRabbit

  • Changes
    • Simplified domain verification status email notifications by removing specific verification error details. Emails now focus on domain status updates only.

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
unsend-marketing Ready Ready Preview, Comment Mar 13, 2026 9:20pm

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Walkthrough

The PR removes the verificationError parameter from domain status notification handling. The DomainVerificationStatusEmail component no longer accepts a verificationError prop, and the sendDomainStatusNotification function signature is updated to exclude this parameter and its usages. Domain verification continues to compute and return verification errors in results, but these errors are no longer included in email notifications. Email body and subject now rely solely on domain status and previous status information.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing verification error details from domain verification emails to simplify them.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying usesend with  Cloudflare Pages  Cloudflare Pages

Latest commit: b877c8a
Status: ✅  Deploy successful!
Preview URL: https://c5491bb8.usesend.pages.dev
Branch Preview URL: https://fix-domain-notification-copy.usesend.pages.dev

View logs

@KMKoushik KMKoushik merged commit d7b196c into main Mar 13, 2026
7 checks passed
@KMKoushik KMKoushik deleted the fix/domain-notification-copy branch March 13, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant