Skip to content

fix: simplify domain verification emails #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KMKoushik merged 1 commit into from
Mar 13, 2026
+0 −30
Merged

fix: simplify domain verification emails #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions apps/web/src/server/email-templates/DomainVerificationStatusEmail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ interface DomainVerificationStatusEmailProps {
domainName: string;
currentStatus: DomainStatus;
previousStatus: DomainStatus;
verificationError?: string | null;
domainUrl: string;
}

Expand All @@ -37,7 +36,6 @@ export function DomainVerificationStatusEmail({
domainName,
currentStatus,
previousStatus,
verificationError,
domainUrl,
}: DomainVerificationStatusEmailProps) {
const isSuccess = currentStatus === DomainStatus.SUCCESS;
Expand Down Expand Up @@ -89,29 +87,6 @@ export function DomainVerificationStatusEmail({
</Text>
)}

{verificationError ? (
<Container
style={{
backgroundColor: "#fef2f2",
border: "1px solid #fecaca",
padding: "12px 16px",
margin: "0 0 24px 0",
borderRadius: "4px",
}}
>
<Text
style={{
margin: 0,
color: "#991b1b",
fontSize: 14,
textAlign: "left" as const,
}}
>
Verification error: {verificationError}
</Text>
</Container>
) : null}

<Text
style={{
fontSize: "14px",
Expand Down
5 changes: 0 additions & 5 deletions apps/web/src/server/service/domain-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,11 +243,9 @@ function shouldSendDomainStatusNotification({
async function sendDomainStatusNotification({
domain,
previousStatus,
verificationError,
}: {
domain: Domain;
previousStatus: DomainStatus;
verificationError: string | null;
}) {
const recipients = (
await db.teamUser.findMany({
Expand Down Expand Up @@ -282,7 +280,6 @@ async function sendDomainStatusNotification({
domainName: domain.name,
currentStatus: domain.status,
previousStatus,
verificationError,
domainUrl,
});
const statusMessage =
Expand All @@ -293,7 +290,6 @@ async function sendDomainStatusNotification({
"Hey,",
null,
statusMessage,
verificationError ? `Verification error: ${verificationError}` : null,
null,
`Open domain settings: ${domainUrl}`,
null,
Expand Down Expand Up @@ -554,7 +550,6 @@ export async function refreshDomainVerification(
await sendDomainStatusNotification({
domain: updatedDomain,
previousStatus,
verificationError,
});
await setLastNotifiedDomainStatus(domain.id, updatedDomain.status);
} catch (error) {
Expand Down
Loading