demonstrate mjs file identified as esm, but handled as cjs#364
Draft
demonstrate mjs file identified as esm, but handled as cjs#364
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
Member
|
@cb1kenobi This test is passing https://github.com/vercel/nft/actions/runs/6384547761/job/17327429573?pr=364#step:8:6107 Is that because it doesn't set |
Contributor
Author
|
@styfle Correct. I didn't commit the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
.mjsfile is traced, it adds allimportintodepsinstead ofimports. Later in the tracing, it treatsdepsas CJS and it incorrectly resolves the default export for theplaywright-corepackage.This regression was introduced by #362, but that PR does fix the issue of CJS files being resolved incorrectly.
I don't know the background, but it seems all
imports, especially in.mjsfiles, should go intoimports, notdeps.@styfle can you please advise?
Test failure: