fix: do not follow absolute paths outside job base#568
Open
teemingc wants to merge 5 commits intovercel:mainfrom
Open
fix: do not follow absolute paths outside job base#568teemingc wants to merge 5 commits intovercel:mainfrom
teemingc wants to merge 5 commits intovercel:mainfrom
Conversation
teemingc
commented
Feb 19, 2026
| // disregard the `bar` in `export { foo as bar }` | ||
| case 'ExportSpecifier': | ||
| return false; | ||
| return node.name === parent.exported.name; |
Author
There was a problem hiding this comment.
This was a drive-by fix. Seems to be more in line with the comment above which checks if it's just export { foo } or aliased
teemingc
requested review from
a team,
icyJoseph,
ijjk and
styfle
as code owners
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to sveltejs/kit#13764 (comment)
SvelteKit stringifies environment variables during build so that it can inject static values into the build output instead of always reading the env vars dynamically. However,
@vercel/nftinterprets any absolute path as an asset it should add. This causes builds on Vercel's build system to balloon in function size because it traces and bundles paths such as Node, Yarn global, etc. Often, this causes the deployment to fail because the function size exceeds the limit.This PR ensures asset paths outside the given job base are ignored to help us avoid packaging in system dependencies.
Draft for now because I'm not confident that this fix doesn't break lots of other things