fix: bump @rollup/plugin-commonjs to v19, fix #3312#3353
Merged
patak-dev merged 1 commit intovitejs:mainfrom May 11, 2021
nihalgonsalves:ng/rollup-commonjs-3312
Merged
fix: bump @rollup/plugin-commonjs to v19, fix #3312#3353patak-dev merged 1 commit intovitejs:mainfrom nihalgonsalves:ng/rollup-commonjs-3312
patak-dev merged 1 commit intovitejs:mainfrom
nihalgonsalves:ng/rollup-commonjs-3312
Conversation
- v18 added the `ignoreDynamicRequires` option as a breaking change. The earlier behaviour matched `true`, so I set it as the default (ref: rollup/plugins#819) - v19 is a breaking change since it now requires Rollup 2.38.0, but we’re already on 2.38.5. (ref: rollup/plugins#658)
Shinigami92
approved these changes
May 11, 2021
patak-dev
approved these changes
May 11, 2021
fi3ework
pushed a commit
to fi3ework/vite
that referenced
this pull request
May 22, 2021
- v18 added the `ignoreDynamicRequires` option as a breaking change. The earlier behaviour matched `true`, so I set it as the default (ref: rollup/plugins#819) - v19 is a breaking change since it now requires Rollup 2.38.0, but we’re already on 2.38.5. (ref: rollup/plugins#658)
Member
and But as the CommonJS plugin is mainly used for third-party dependencies in Vite apps, I think the latter use case is very rare, and it seems not quite useful either. |
Member
|
Fixing the Though, that issue seems also to be a Rollup bug. So it's not a very urgent issue here. |
|
This new default broke my build. On It'd be nice to get types for the override option, too. |
haoqunjiang
added a commit
to haoqunjiang/vite
that referenced
this pull request
Jun 29, 2021
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Jun 29, 2021
See #3353 (comment) Fixes #3426 Fixes #3997
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3312
ignoreDynamicRequiresoption as a breaking change. The earlier behaviour matchedtrue, so I set it as the default (ref: feat(commonjs): Add ignore-dynamic-requires option rollup/plugins#819)Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).