Fix key-seq bindings silently ignored by key-chord optimization#5
Open
lewang wants to merge 3 commits intovlevit:masterfrom
Open
Fix key-seq bindings silently ignored by key-chord optimization#5lewang wants to merge 3 commits intovlevit:masterfrom
lewang wants to merge 3 commits intovlevit:masterfrom
Conversation
key-chord has an optimization where the input method skips chord detection for keys not registered in any chord. key-seq-define was not calling key-chord-register-keys, so defined sequences could be silently ignored. Call register/unregister to keep the two packages in sync.
lewang
force-pushed
the
register-chord-keys
branch
from
b2b8f74 to
f7e2712
Compare
added 2 commits
February 21, 2026 06:53
Silence native-compiler warnings for key-chord-register-keys and key-chord-unregister-keys which are called conditionally via fboundp.
lewang
force-pushed
the
register-chord-keys
branch
from
f7e2712 to
3b39d74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
key-seq-definefell out of sync withkey-chord-definein two ways:Key tracking — key-chord's input method now skips chord detection for keys not registered via
key-chord-register-keys(Improve performance, add typing detection emacsorphanage/key-chord#12).key-seq-definenever called this, so key-seq bindings could be silently ignored. Callkey-chord-register-keys/key-chord-unregister-keysafter defining/removing a binding, guarded withfboundpfor backward compatibility.Key validation — Replace the old
logand 255masking (which silently truncated invalid keys) with explicit type and range checking, matching key-chord's current validation.Also enable
lexical-binding, which the file was missing.