Skip to content

Fix key-seq bindings silently ignored by key-chord optimization #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lewang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix key-seq bindings silently ignored by key-chord optimization #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
585b5e8
Register keys with key-chord's tracking optimization
Feb 21, 2026
bcd4944
Enable lexical-binding
Feb 21, 2026
3b39d74
Add declare-function for key-chord functions
Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions key-seq.el
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
;;; key-seq.el --- map pairs of sequentially pressed keys to commands
;;; key-seq.el --- map pairs of sequentially pressed keys to commands -*- lexical-binding: t; -*-

;; Copyright (C) 2015 Vyacheslav Levit
;; Copyright (C) 2003,2005,2008,2012 David Andersson
Expand Down Expand Up @@ -62,6 +62,9 @@

;;; Code:

(declare-function key-chord-register-keys "key-chord" (key1 key2))
(declare-function key-chord-unregister-keys "key-chord" (key1 key2))

;;;###autoload
(defun key-seq-define-global (keys command)
"Define a key sequence of the two keys in KEYS starting a COMMAND.
Expand Down Expand Up @@ -94,12 +97,20 @@ that corresponds to ascii codes in the range 32 to 126 can be used.
If COMMAND is nil, the key-chord is removed."
(if (/= 2 (length keys))
(error "Key-chord keys must have two elements"))
;; Exotic chars in a string are >255 but define-key wants 128..255 for those
(let ((key1 (logand 255 (aref keys 0)))
(key2 (logand 255 (aref keys 1))))
(let ((key1 (aref keys 0))
(key2 (aref keys 1)))
(unless (and (integerp key1) (< key1 256)
(integerp key2) (< key2 256))
(error "Key-seq keys must both be bytes (characters with codes < 256)"))
(if (eq key1 key2)
(define-key keymap (vector 'key-chord key1 key2) command)
(define-key keymap (vector 'key-chord key1 key2) command))))
(define-key keymap (vector 'key-chord key1 key2) command))
;; Register keys with key-chord's tracking optimization so the
;; input method doesn't skip chord detection for these keys.
(when (fboundp 'key-chord-register-keys)
(if command
(key-chord-register-keys key1 key2)
(key-chord-unregister-keys key1 key2)))))

(defun key-seq-unset-global (keys)
"Remove global key sequence of the two keys in KEYS."
Expand Down