feat: add strong type safety for IconDefinition callbacks and support some object options#13
Open
danilo-arioli wants to merge 9 commits intowaspeer:mainfrom
Open
feat: add strong type safety for IconDefinition callbacks and support some object options#13danilo-arioli wants to merge 9 commits intowaspeer:mainfrom
danilo-arioli wants to merge 9 commits intowaspeer:mainfrom
Conversation
Owner
|
Thank you for this comprehensive pr!! I'll have some time hopefully tomorrow to go over it. |
Author
|
Thank you! I also added the initialValue type, which I realized I’d forgotten earlier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds full type safety to the IconDefinition schema type. Schema callbacks that use the icon field now receive correct types for the value parameter in validation, hidden, and readOnly. It also introduces the collapsible and collapsed object options to IconDefinition and adds tests covering these changes.
Before
After