Skip to content

feat: add strong type safety for IconDefinition callbacks and support some object options #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danilo-arioli wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: add strong type safety for IconDefinition callbacks and support some object options #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ac363d
feat: make IconDefinition strongly typed
danilo-arioli Dec 19, 2025
0146533
feat: add tests
danilo-arioli Dec 19, 2025
c85dbc4
fix: export icon definitions directly from the plugin instead of sani…
danilo-arioli Dec 19, 2025
cc59969
fix: remove preview in IconDefinition and add necessary types to bundle
danilo-arioli Dec 19, 2025
cafadd9
feat: add collapsed and collapsible properties to IconDefinition options
danilo-arioli Dec 19, 2025
39a42e7
fix: move collapsed and collapsible properties to IconOptions
danilo-arioli Dec 19, 2025
0745cb7
fix: consider that icon value can also be undefined
danilo-arioli Dec 19, 2025
ed6b478
test: expect value to extend IconValue, which can also be undefined
danilo-arioli Dec 19, 2025
c4b7fff
feat: add initialValue type in IconDefinition
danilo-arioli Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
"generate-types": "node src/lib/generate-types",
"lint": "eslint .",
"release": "release-it",
"test": "vitest run",
"test:ui": "vitest --ui",
"test:watch": "vitest",
"watch": "pkg-utils watch --strict"
},
"browserslist": "extends @sanity/browserslist-config",
Expand Down Expand Up @@ -74,6 +77,7 @@
"@tanstack/react-query-devtools": "^5.89.0",
"@types/react": "^19.1.13",
"@types/styled-components": "^5.1.34",
"@vitest/ui": "^4.0.16",
"@waspeer/config": "^2.4.5",
"eslint": "^9.35.0",
"lefthook": "^1.13.1",
Expand All @@ -87,7 +91,8 @@
"sanity": "^4.9.0",
"tsx": "^4.20.5",
"typescript": "^5.9.2",
"vite": "^7.1.6"
"vite": "^7.1.6",
"vitest": "^4.0.16"
},
"peerDependencies": {
"react": "^18 || ^19",
Expand Down
Loading