[FEATURE] Make MimicKit installable as a package#92
Open
Kashu7100 wants to merge 2 commits intoxbpeng:mainfrom
Open
[FEATURE] Make MimicKit installable as a package#92Kashu7100 wants to merge 2 commits intoxbpeng:mainfrom
Kashu7100 wants to merge 2 commits intoxbpeng:mainfrom
Conversation
Owner
|
Thanks a lot for putting together this PR! This looks like it could be useful. But we probably won't be making this change for now. But I think it would still be beneficial to keep this PR around, in case others might find it useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip-installable via setuptools. Defines project metadata (name,
version 0.1.0, license, authors), lists all dependencies (previously
in requirements.txt), and configures package discovery to include
mimickit*.
section in pyproject.toml.
mimickit/ package directory onto sys.path. This preserves backward
compatibility with the project's internal flat imports (e.g., import
learning.ppo_agent) which expect submodules to be importable
directly, regardless of whether the code is run as a script or
imported from an installed package.