Extract fixed pool calculation helpers #2420
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted duplicated fixed pool calculation logic from distributorv2.ts into shared helper functions in fixed-pool-calculation.ts. This enables both backend distributor and frontend UI to use the same calculation logic, ensuring consistency. Where: - Created apps/distributor/src/fixed-pool-calculation.ts - calculateMultiplier: handles verification type multiplier logic - calculateCombinedMultiplier: combines multiple multipliers - calculateSlashPercentage: calculates progress/slash percentage - calculateBaseFixedAmount, calculateFixedPoolAmount helpers - Refactored apps/distributor/src/distributorv2.ts to use new helpers - Updated packages/app/features/rewards/activity/screen.tsx ProgressCard to use calculateSlashPercentage ensuring UI matches backend - Added verified_count to fetchDistributions query (distributions.ts) to support future percentile calculations Why: Fixed pool calculation logic was duplicated between distributorv2.ts (lines 602-660) and UI approximations. Pure functions enable code reuse and guarantee backend and frontend calculate identically. Pattern from: apps/distributor/src/weights.ts calculatePercentageWithBips Test plan: - npm run distributor:dev Expected: Distribution output identical to previous run - Verify ProgressCard displays slash percentage matching distributor logs - npm run biome:check apps/distributor/src/fixed-pool-calculation.ts Expected: No errors
This was referenced Dec 30, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted duplicated fixed pool calculation logic from distributorv2.ts
into shared helper functions in fixed-pool-calculation.ts. This enables
both backend distributor and frontend UI to use the same calculation
logic, ensuring consistency.
Where:
to use calculateSlashPercentage ensuring UI matches backend
to support future percentile calculations
Why:
Fixed pool calculation logic was duplicated between distributorv2.ts
(lines 602-660) and UI approximations. Pure functions enable code reuse
and guarantee backend and frontend calculate identically.
Pattern from: apps/distributor/src/weights.ts calculatePercentageWithBips
Test plan:
Expected: Distribution output identical to previous run
Expected: No errors