Add calculatePercentileFromRank helper function #2423
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: With raw rank storage, clients need to calculate percentile on-demand. Add helper function using formula: (rank / (totalCount - 1)) * 100 This enables flexible client-side transformations like: - Percentile display: "Top 15%" - Rank display: "Rank #42 of 280" - Percentage: "You're in the 85th percentile" Changes: - Added calculatePercentileFromRank(rank, totalCount) function - Returns percentile 0-100 (100 = highest balance) - Handles edge case: totalCount <= 1 returns 50 Pattern from: apps/distributor/src/weights.ts lines 134, 147 (original percentile calculation: const percentile = n > 1 ? (rank / (n - 1)) * 100 : 50) Test plan: - Unit test: calculatePercentileFromRank(0, 100) returns 0 - Unit test: calculatePercentileFromRank(99, 100) returns 100 - Unit test: calculatePercentileFromRank(50, 101) returns 50 - Edge case: calculatePercentileFromRank(0, 1) returns 50
Add comprehensive test coverage for the calculatePercentileFromRank helper function that calculates client-side percentiles from raw rank values. Tests cover: - Edge cases (single user, zero count) - Boundary values (rank 0, rank max) - Middle values for validation - Large totalCount values - Formula verification against migration comment All 12 tests passing. Pattern from: packages/app/utils/fixed-pool-calculation.test.ts (vitest test structure and assertion patterns) Co-Authored-By: Warp <agent@warp.dev>
This was referenced Dec 30, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calculatePercentileFromRank helper function
Why:
With raw rank storage, clients need to calculate percentile on-demand.
Add helper function using formula: (rank / (totalCount - 1)) * 100
This enables flexible client-side transformations like:
Changes:
Pattern from: apps/distributor/src/weights.ts lines 134, 147
(original percentile calculation: const percentile = n > 1 ? (rank / (n - 1)) * 100 : 50)
Test plan:
test: Add unit tests for calculatePercentileFromRank
Add comprehensive test coverage for the calculatePercentileFromRank helper
function that calculates client-side percentiles from raw rank values.
Tests cover:
All 12 tests passing.
Pattern from: packages/app/utils/fixed-pool-calculation.test.ts
(vitest test structure and assertion patterns)
Co-Authored-By: Warp agent@warp.dev