Fetch balance_rank instead of balance_rank_percentile #2422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Update query to fetch balance_rank (integer) instead of balance_rank_percentile (numeric). Aligns with schema change to store raw rank values instead of calculated percentiles. Changes: - Query field: balance_rank_percentile → balance_rank - Returns raw 0-based rank integer from database Pattern from: packages/app/utils/distributions.ts line 87 (index field - another integer field in distribution_shares) Test plan: - Run app: npm run web - Navigate to distributions screen - Verify data loads without errors - Check network tab: distribution_shares query should include balance_rank field
This was referenced Dec 30, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Update query to fetch balance_rank (integer) instead of
balance_rank_percentile (numeric). Aligns with schema change
to store raw rank values instead of calculated percentiles.
Changes:
Pattern from: packages/app/utils/distributions.ts line 87
(index field - another integer field in distribution_shares)
Test plan: