Mitigate undesired unsynchronized effect of changing SwapchainImage Count#495
Merged
JeanPhilippeKernel merged 2 commits intoJeanPhilippeKernel:user/kernel/fix-updateafter-from Jan 28, 2026
Conversation
MathewBensonCode
changed the title
JeanPhilippeKernel
changed the base branch from
develop
to
user/kernel/fix-updateafter-
Owner
|
I believe, addressing the conflict should reduce the file change and keep your changes on |
JeanPhilippeKernel
added
area-rendering
area-linux
- The code that relies on the SwapchainImageCount such as the command buffer are re-arranged to ensure that they run after we establish the correct number of Swapchain Images
MathewBensonCode
force-pushed
the
afterbind
branch
from
c31b438 to
1660e12
Compare
JeanPhilippeKernel
requested changes
Jan 28, 2026
Contributor
Author
|
I would like to confirm that as at the last commit, the application is running successfully on linux. Its actually the first time I have seen the UI running since I started looking at this project a few years ago. i'll take a look at the changes requested a little later. |
- Removed Redundant parameter to the CommandBufferManager.Initialize method - Moved the EnquedCommandBuffers.init method to be called right after the m_buffer_manager.Initialize function call
JeanPhilippeKernel
merged commit 9957616
into
JeanPhilippeKernel:user/kernel/fix-updateafter-
jnyfah
pushed a commit
that referenced
this pull request
Feb 2, 2026
* updated vulkan device * added update-after-bind detection * fixed binding name cmp ops * updated bindless logic * fixed missing props * simplified expr * reduced descriptorset usage * fixed descriptor set count logic * Mitigate undesired unsynchronized effect of changing SwapchainImage Count (#495) * Re-Arrange Code flow after swapchainimage count change - The code that relies on the SwapchainImageCount such as the command buffer are re-arranged to ensure that they run after we establish the correct number of Swapchain Images * Pull Request #495 Requested Changes - Removed Redundant parameter to the CommandBufferManager.Initialize method - Moved the EnquedCommandBuffers.init method to be called right after the m_buffer_manager.Initialize function call --------- Co-authored-by: Mathew Benson <mathew@benson.co.ke> * improved buffer manager * prevent swapchain image count change in after first creation * fixed string deref * filled dummy set for imgui * fixed usage of Shader LocalArena * fixed rendering on wrong framebuffer --------- Co-authored-by: Mathew Benson <benson.orina@live.com> Co-authored-by: Mathew Benson <mathew@benson.co.ke>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating the Swapchain we check with the device for the supported value. If this value is higher than the pre-configured values, structures created with the initial values are now out of sync, leading to crashes.
This approach attemps to create those structures after getting the supported Swapchain image count