Skip to content

feature/fe coupling Initial phase#11

Merged
jsauer-NCAR merged 4 commits intodevelopfrom
feature/fe_coupling
Mar 28, 2025
Merged

feature/fe coupling Initial phase#11
jsauer-NCAR merged 4 commits intodevelopfrom
feature/fe_coupling

Conversation

@jsauer-NCAR
Copy link
Collaborator

Expected Differences

  • [x ] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

    Yes this PR introduces limited-area domain, dirichlet boundary condition capabilities for coupling to a parent simulation under the parameter hydrBCs=1

Pull Request Testing

  • [x ] Describe testing already performed for these changes:

    Basic testing of a single real case scenario targeted as the tutorial case that will accompany the v3.0 release of this capability.
  • [ x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None at this time. A subsequent PR will likely be required to finalize this feature addition.
  • [ x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    RTD-based documentation is being developed in the upstream NCAR/FE-model repository
  • [x ] Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • [x ] Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    N/A
  • [ x] Please complete this pull request review by [Fill in date].

    3/28/2025

Pull Request Checklist

  • [x ] Complete the PR definition above.
  • [x ] Ensure the PR title matches the feature or bugfix branch name.
  • [x ] Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jsauer-NCAR jsauer-NCAR requested a review from domingom March 28, 2025 19:01
@jsauer-NCAR
Copy link
Collaborator Author

Given that we have carefully reviewed all of the modifications in this PR together over the last couple days, I'll go ahead and proceed with the merge at this time without waiting for 'github' review.

@jsauer-NCAR jsauer-NCAR merged commit 1efdab4 into develop Mar 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants