Merged
Conversation
…Cs from Bndy files.
… adding self-consistent formulations of th0 (omitting any use of pres_grnd) in surface layer schemes.
Collaborator
Author
|
Given that we have carefully reviewed all of the modifications in this PR together over the last couple days, I'll go ahead and proceed with the merge at this time without waiting for 'github' review. |
This was referenced Mar 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Yes this PR introduces limited-area domain, dirichlet boundary condition capabilities for coupling to a parent simulation under the parameter hydrBCs=1
Pull Request Testing
Basic testing of a single real case scenario targeted as the tutorial case that will accompany the v3.0 release of this capability.
None at this time. A subsequent PR will likely be required to finalize this feature addition.
RTD-based documentation is being developed in the upstream NCAR/FE-model repository
N/A
If yes, describe the new output and/or changes to the existing output:
N/A
3/28/2025
Pull Request Checklist