oape: API types and tests from EP #1834#108
oape: API types and tests from EP #1834#108swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.1from
Conversation
Adds NetworkPolicy API type improvements and comprehensive integration tests for the ExternalSecretsConfig networkPolicies field from EP #1834. Changes: - Fix godoc comments on ComponentName constants (trailing periods) - Add DNS subdomain validation pattern for NetworkPolicy name field - Improve Egress field documentation for clarity - Fix Egress JSON tag (remove omitempty for Required field) - Fix listType marker spacing - Add 15 new integration test cases covering: - NetworkPolicy creation for CoreController and BitwardenSDKServer - Multiple networkPolicies in a single config - Allow-all egress and deny-all egress configurations - DNS name validation (uppercase, underscores, leading/trailing hyphens) - Empty networkPolicies list handling - Name length validation - Invalid componentName validation - NetworkPolicy addition after creation (onUpdate) - Immutability of name and componentName fields (onUpdate) - Regenerated CRD manifests with updated validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
networkPoliciesfield inExternalSecretsConfigAuto-generated API type definitions and integration tests from openshift/enhancements#1834
Test plan
make buildpassesmake testpasses (67/67 specs)🤖 Generated with Claude Code