Skip to content

Comments

oape: API types and tests from EP #1834#108

Open
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.1from
swghosh:oape/api-types-1834
Open

oape: API types and tests from EP #1834#108
swghosh wants to merge 1 commit intoopenshift:ai-staging-release-1.1from
swghosh:oape/api-types-1834

Conversation

@swghosh
Copy link
Member

@swghosh swghosh commented Feb 19, 2026

Summary

  • Improve NetworkPolicy API type definitions with DNS subdomain validation and better documentation
  • Add 15 comprehensive integration test cases for the networkPolicies field in ExternalSecretsConfig
  • Fix convention compliance issues (godoc, JSON tags, marker spacing)
  • Regenerate CRD manifests

Auto-generated API type definitions and integration tests from openshift/enhancements#1834

Test plan

  • make build passes
  • make test passes (67/67 specs)
  • CRD manifests regenerated and consistent

🤖 Generated with Claude Code

Adds NetworkPolicy API type improvements and comprehensive integration
tests for the ExternalSecretsConfig networkPolicies field from EP #1834.

Changes:
- Fix godoc comments on ComponentName constants (trailing periods)
- Add DNS subdomain validation pattern for NetworkPolicy name field
- Improve Egress field documentation for clarity
- Fix Egress JSON tag (remove omitempty for Required field)
- Fix listType marker spacing
- Add 15 new integration test cases covering:
  - NetworkPolicy creation for CoreController and BitwardenSDKServer
  - Multiple networkPolicies in a single config
  - Allow-all egress and deny-all egress configurations
  - DNS name validation (uppercase, underscores, leading/trailing hyphens)
  - Empty networkPolicies list handling
  - Name length validation
  - Invalid componentName validation
  - NetworkPolicy addition after creation (onUpdate)
  - Immutability of name and componentName fields (onUpdate)
- Regenerated CRD manifests with updated validation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant